Fix SQL error in plugin_history. #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since merging s9y#665 `serendipity_plugin_history` breaks with a SQL error message on every archive page but the first one; see s9y#693 for reason and context. Unset `$serendipity['GET']['page']` before calling `serendipity_fetchEntries(`)` (and reset afterwards) to fix that. That's the correct way, I think, as `serendipity_fetchEntries()` is not called in page context here. Signed-off-by: Thomas Hochstein <thh@inter.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since merging #665
serendipity_plugin_historybreaks with a SQL error message on every archive page but the first one; see #693 for reasons and context.Unset
$serendipity['GET']['page']before callingserendipity_fetchEntries()(and reset afterwards) to fix that. That's the correct way, I think, asserendipity_fetchEntries()is not called in page context here.Signed-off-by: Thomas Hochstein thh@inter.net