Wip/codecs shards #135
Draft
Wip/codecs shards #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/janelia/saalfeldlab/n5/GsonKeyValueN5Reader.java
* DeterministicSizeCodec and Crc32cChecksumCodec
* move some functionality to ChecksumCodec
* to match zarr v3
test,build: include n5-universe for tests
* edit behavior of getIndex
* this may make more sense in a more basic interface
* no need for getCompressionAsCodec * use getType for codecs
* add ShardProperties test
* where readBlocks batches when possible
* so that we can index by position * primitive long arrays are not great as keys for maps
* shardsPerImage, blocksPerImage * grouping DataBlocks by shard postion * stream of block positions ordered by shard
* methods in GridIterator replaces this
* Using Position class * using ShardParameters.groupBlocks helper method
* use it to return early for getBlocks
* but ignore it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.