[BUGFIX] fix usages of allowTableOnStandardPages with mutliple tablen…

…ames in one string (#4276)
sabbelasichon · May 25, 2024 · 12db6fa · 12db6fa
1 parent 982a702
commit 12db6fa
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 6 deletions.
diff --git a/rules/TYPO312/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector.php b/rules/TYPO312/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector.php
@@ -87,12 +87,16 @@ public function refactor(Node $node)
             return null;
         }
 
-        $tableName = $this->valueResolver->getValue($tableArgument);
-
-        $directoryName = dirname($this->file->getFilePath());
-        $newConfigurationFile = $directoryName . '/Configuration/TCA/Overrides/' . $tableName . '.php';
-        $this->writeConfigurationToFile($newConfigurationFile, $tableName);
-
+        $tableNames = $this->valueResolver->getValue($tableArgument);
+
+        foreach (explode(',', $tableNames) as $tableName) {
+            if (!$tableName) {
+                continue;
+            }
+            $directoryName = dirname($this->file->getFilePath());
+            $newConfigurationFile = $directoryName . '/Configuration/TCA/Overrides/' . $tableName . '.php';
+            $this->writeConfigurationToFile($newConfigurationFile, $tableName);
+        }
         return NodeTraverser::REMOVE_NODE;
     }
 

diff --git a/.../v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Assertions/tx_table_one.php.inc b/.../v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Assertions/tx_table_one.php.inc
@@ -0,0 +1,3 @@
+<?php
+
+$GLOBALS['TCA']['tx_table_one']['ctrl']['security']['ignorePageTypeRestriction'] = true;
diff --git a/.../v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Assertions/tx_table_two.php.inc b/.../v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Assertions/tx_table_two.php.inc
@@ -0,0 +1,3 @@
+<?php
+
+$GLOBALS['TCA']['tx_table_two']['ctrl']['security']['ignorePageTypeRestriction'] = true;
diff --git a/...r/v12/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Fixture/ext_tables.php.inc b/...r/v12/v0/MoveAllowTableOnStandardPagesToTCAConfigurationRector/Fixture/ext_tables.php.inc
@@ -6,6 +6,7 @@ use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 
 ExtensionManagementUtility::allowTableOnStandardPages('tx_table_with_existing_tca_configuration_file');
 ExtensionManagementUtility::allowTableOnStandardPages('tx_table_without_existing_tca_configuration_file');
+ExtensionManagementUtility::allowTableOnStandardPages('tx_table_one,tx_table_two');
 
 ?>
 -----

diff --git a/...gesToTCAConfigurationRector/MoveAllowTableOnStandardPagesToTCAConfigurationRectorTest.php b/...gesToTCAConfigurationRector/MoveAllowTableOnStandardPagesToTCAConfigurationRectorTest.php
@@ -39,6 +39,14 @@ public function test(): void
             __DIR__ . '/Fixture/Configuration/TCA/Overrides/%s.php',
             'tx_table_with_existing_tca_configuration_file'
         );
+        $this->assertThatConfigurationFileHasNewIgnorePageTypeRestriction(
+            __DIR__ . '/Fixture/Configuration/TCA/Overrides/%s.php',
+            'tx_table_one'
+        );
+        $this->assertThatConfigurationFileHasNewIgnorePageTypeRestriction(
+            __DIR__ . '/Fixture/Configuration/TCA/Overrides/%s.php',
+            'tx_table_two'
+        );
     }
 
     public function provideConfigFilePath(): string