empty labels for checkbox items are removed

[DavidBruchmann]

Bug Report

Subject	Details
Rector version	at least 2.2 - 2.4

In definitions like this:

            'config' => [
                'type' => 'check',
                'items' => [
                    [
                        'label' => '',
                    ],
                ],
            ],

the item-array gets completely removed by the typo3-rector rules SimplifyCheckboxItemsTCARector and MigrateItemsIndexedKeysToAssociativeRector, both have to be excluded to keep the definitions.

Minimal PHP Code Causing Issue

Sorry, I don't know how to load the Ssch namespace there:
https://getrector.com/demo/890354e6-9ea1-439a-95d7-fe7bf1e798eb

Expected Behaviour

the "items" array is required by TYPO3 and shouldn't be removed entirely.
One item with label is also required, even if it's empty.

[DavidBruchmann]

Docu v12
Docu v11

[simonschaufi]

The website getrector.com doesn't include TYPO3 stuff, so this can't work. This used to work in the past though but the template is outedated. sorry.

Changelogs:

• https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.3/Deprecation-99739-IndexedArrayKeysForTCAItems.html
• https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056

Can you please have a a look at both?

I guess this one causes the problem: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056

[DavidBruchmann]

Yes I agree, I just don't know how to make TYPO3 and rector happy with the same notation.
Perhaps @brotkrueml can shine a light on it?

The contradiction seems being inside TYPO3 itself already, I think.

[simonschaufi]

The best is to have a look at the styleguide extension.

Having a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056/2/typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php#b505 it might be that my migration is wrong. Let me add a test case...

[DavidBruchmann]

your example looks outdated as it never has the label key

[simonschaufi]

No, in this case both rules depend on each other. This should just remove index 1 and the other one linked above should then change index 0 to "label".

[DavidBruchmann]

ok, I can't follow completely, as my example looks differently, but let's see what you're coming forward with