[BUG]: FlexFormToolsArrayValueByPathRector modifies FlexFormTools::cleanFlexFormXML() with non-working code

[sypets]

Minimal PHP Code Causing Issue

in TYPO3 extension Upgrade Wizard:

protected function cleanupXmlArray(array $row): array
{
        $this->flexformTools->cleanFlexFormXML('tt_content', 'pi_flexform', $row);
        $xmlArray = $this->flexformTools->cleanFlexFormXML;
        return $xmlArray;
}

Applied rules

FlexFormToolsArrayValueByPathRector

with changelog: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Deprecation-95254-TwoFlexFormToolsMethods.html

The code is changed like this:

 protected function cleanupXmlArray(array $row): array
 {
-        $this->flexformTools->cleanFlexFormXML('tt_content', 'pi_flexform', $row);
+        $dataArray = \TYPO3\CMS\Core\Utility\ArrayUtility::setValueByPath('pi_flexform', 'tt_content', $row);
         $xmlArray = $this->flexformTools->cleanFlexFormXML;
         return $xmlArray;
 }

Expected Behaviour

I think rector should (if in doubt) skip this code. cleanFlexFormXML is AFAIK not deprecated yet. Also, the change in code is not as intended:

• FlexFormTools::cleanFlexFormXML() sets $this->cleanFlexFormXML
• the array function and result $dataArray assigned, but not used
• $this->flexformTools->cleanFlexFormXML is returned (which is not initialized)
• not sure if Flexform is cleaned as intended

Package Version

2.6.0

PHP Version

8.2.20

TYPO3 Version

11.5.38

Notes

No response