Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent double required config key in TCA #3451

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: prevent double required config key in TCA #3451

merged 1 commit into from
Aug 9, 2023

Conversation

helsner
Copy link
Collaborator

@helsner helsner commented Aug 5, 2023

Resolves: #3450

@helsner
Copy link
Collaborator Author

helsner commented Aug 5, 2023

hi @sabbelasichon - couldn't get behind this one.. but provided my broken tests
Detected while i did my presentation :D

@sabbelasichon sabbelasichon marked this pull request as ready for review August 9, 2023 09:49
@sabbelasichon sabbelasichon merged commit 38f1a9f into main Aug 9, 2023
16 checks passed
@sabbelasichon sabbelasichon deleted the issue-3450 branch August 9, 2023 10:07
@mikestreety
Copy link

@sabbelasichon @helsner Hey both, can I ask what the reasoning was for adding phpstan as a conflict? I've just updated and have traced the addition back to here but couldn't find the reason for doing so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

double required added
3 participants
@helsner @mikestreety @sabbelasichon