[TASK] Simplify code generation command #3462
Conversation
|
@sabbelasichon I'm throwing a lot of code away and improve the whole code generation by using simple strings and making use of validators where they belong instead of within the normalizer where they were before. Are you ok with the change? |
simonschaufi
force-pushed
the
simple-code-generation
branch
from
7f834cb
to
aa81905
Compare
|
@simonschaufi: I love Value Objects but in this case i don´t know why these value objects are not self validating. I.e. why is the Url Value Object not asserting that the parameter is a valid Url. Why does the description VO is not validating the min and max length? I think the value objects are not valuable in this case, but should be. Throw them away or refactor them to be self validating. |
|
The problem is that there were assertions in them before but when you do something wrong, you have to start all over again which is really annoying. Now you actually have 3 tries until the question exits. That's also in the symfony documentation. No validation in the normaliser! Once you extract the validation out off them, they become useless. |
No description provided.