Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update rector to latest 0.17 version #3639

Closed
wants to merge 1 commit into from
Closed

Conversation

simonschaufi
Copy link
Collaborator

No description provided.

@simonschaufi
Copy link
Collaborator Author

@simonschaufi simonschaufi marked this pull request as draft October 16, 2023 16:14
@mgerdes-atl
Copy link

Hi @simonschaufi ,

any news on the hardcoded dependency of rector/rector 0.17.0 ?
Any updates planned so far?

Regards
Markus

@simonschaufi
Copy link
Collaborator Author

Feel free to give it a try but since there is no clear migration path for rector, it is a huge task. Some things are also removed that we use. I want to focus more on creating rules than updating rector which is more fun 🥳

@sabbelasichon
Copy link
Owner

I am going to close this issue. We should do the migration in baby steps.

@simonschaufi
Copy link
Collaborator Author

@sabbelasichon Upgrading rector 0.17.0 to 0.17.13 is a baby step for me but ok...

@simonschaufi simonschaufi deleted the update-rector branch January 3, 2024 22:45
@sabbelasichon
Copy link
Owner

No, it is not

@simonschaufi
Copy link
Collaborator Author

simonschaufi commented Jan 3, 2024

It really sucks that rector is just throwing things away without giving alternatives and doesn't explain how to migrate code...
I have tried to read through the commits of rector and I felt like this: 🤯

@sabbelasichon
Copy link
Owner

I know. I have been there. It sucks. But what is the alternative? Let's focus on the most important things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants