Skip to content

Commit

Permalink
test: absolute paths in precompiles test
Browse files Browse the repository at this point in the history
  • Loading branch information
@PaulRBerg
PaulRBerg committed May 20, 2024
1 parent 2163084 commit 56ce2b9
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/utils/Precompiles.t.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ pragma solidity >=0.8.22 <0.9.0;

import { LibString } from "solady/src/utils/LibString.sol";

import { Precompiles } from "../../precompiles/Precompiles.sol";
import { ISablierV2LockupDynamic } from "../../src/interfaces/ISablierV2LockupDynamic.sol";
import { ISablierV2LockupLinear } from "../../src/interfaces/ISablierV2LockupLinear.sol";
import { ISablierV2LockupTranched } from "../../src/interfaces/ISablierV2LockupTranched.sol";
import { ISablierV2NFTDescriptor } from "../../src/interfaces/ISablierV2NFTDescriptor.sol";
import { Precompiles } from "precompiles/Precompiles.sol";
import { ISablierV2LockupDynamic } from "src/interfaces/ISablierV2LockupDynamic.sol";
import { ISablierV2LockupLinear } from "src/interfaces/ISablierV2LockupLinear.sol";
import { ISablierV2LockupTranched } from "src/interfaces/ISablierV2LockupTranched.sol";
import { ISablierV2NFTDescriptor } from "src/interfaces/ISablierV2NFTDescriptor.sol";

import { Base_Test } from "../Base.t.sol";

Expand Down

5 comments on commit 56ce2b9

@smol-ninja
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulRBerg there is a reason why we use relative path in Precompiles.t.sol. Its because test/utils is included in npm package.

@PaulRBerg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot - sorry! Feel free to push a revert: commit

@andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented on 56ce2b9 May 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, what if we move Precompiles and Base_Script tests into other dir so that we don't include in the NPM package actual test files, but only utils that can be used?

@smol-ninja @PaulRBerg

@PaulRBerg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea, though where would we put them?

Alternatively, we could use a glob path in files to exclude any *.t.sol files from being included in the npm package.

@andreivladbrg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could use a glob path in files to exclude any *.t.sol files from being included in the npm package.

sgtm #935

Please sign in to comment.