Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total amount in NFT descriptor cards #638

Closed
PaulRBerg opened this issue Jul 25, 2023 · 12 comments
Closed

Add total amount in NFT descriptor cards #638

PaulRBerg opened this issue Jul 25, 2023 · 12 comments
Assignees
Milestone

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Jul 25, 2023

Task

Edit the sidelines to add the total amount next to the token currency.

That is, instead of "EXA", it should say "1.2k EXA".

Context

Requested by Exactly Protocol:

SCR-20230725-qlmr
@PaulRBerg PaulRBerg added this to the V2.x milestone Jul 25, 2023
@PaulRBerg
Copy link
Member Author

@razgraf thoughts:

One possible place to add this bit of info would be the edge animated text (e.g. near the token symbol, "0x... - EXA 200")

@PaulRBerg
Copy link
Member Author

Any thoughts on replacing the duration card with the total amount card, @razgraf?

The total amount is a more useful bit of information than the total duration. The latter is particular for each user - when they started the stream, if there's a cliff, etc. In contrast, the total amount is a more definite property.

@razgraf
Copy link
Member

razgraf commented Aug 23, 2023

Hmm not sure I see why the amount would be more definite, both duration and amount are immutable.
Nevertheless, I still think we should include the total amount somewhere. The suggestion to add it on the edges had two reasons behind:

  1. easier to add in code
  2. I'm a bit wary of the UI bleeding out with two amount boxes side by side (we need to test some scenarios before swapping the duration box for another amount box)

Even if we go with the replacement, I'd still keep the duration in the NFT as well - so the choice becomes:

  • amount in box, duration on edge
  • amount on edge, duration in box

@PaulRBerg
Copy link
Member Author

not sure I see why the amount would be more definite

There are lots of properties that can be interpreted as a "duration": total duration, remaining duration, cliffs, segments.

I'm a bit wary of the UI bleeding out with two amount boxes side by side

I don't see any problem with this, but anyway.

I'd still keep the duration in the NFT as well

As per the vagueness point above, I wouldn't.

In any case, no strong preference. Happy to defer to you.

What if we turn the side text where it says "EXA" into "1.2k EXA"?

@PaulRBerg
Copy link
Member Author

Yet another request for this feature, now coming from NFTFI.

Another Q: Is it possible to add in the total stream amount to the image on OpenSea? It is missing some key details. We would love to include a vid/gif of the image in our tweet thread

@razgraf
Copy link
Member

razgraf commented Aug 29, 2023

What if we turn the side text where it says "EXA" into "1.2k EXA"?

I think this was the initial suggestion, right?

By the way, in light of #671 we could also limit the "live" aspect of our NFT by replacing some attributes with approximations or ones that evolve slower.

@PaulRBerg
Copy link
Member Author

I think this was the #638 (comment) suggestion, right?

Yep, but I was not sure where exactly on the side lines you wanted to place the amount.

we could also limit the "live" aspect of our NFT

I'll follow up in that discussion thread.

@PaulRBerg PaulRBerg assigned PaulRBerg and unassigned andreivladbrg Aug 30, 2023
@PaulRBerg
Copy link
Member Author

The more I think about this issue, the more I realize that the total amount is much more important than the streamed amount. This value is especially important for NFT lending, but also for simple payments - you care about how much this particular stream will eventually give you.

Are you guys cool with replacing the streamed amount with the total amount?

TBH nobody will notice the total amount if we put it on the sidelines.

@razgraf
Copy link
Member

razgraf commented Sep 15, 2023

SGTM!

@PaulRBerg
Copy link
Member Author

Great, @andreivladbrg you can work on this task in your next sprint.

@andreivladbrg
Copy link
Member

Great, @andreivladbrg you can work on this task in your next sprint.

Yes, which word should we use as a replacement? Instead of "Streamed", should we use "Amount"? I think "Total Amount" might be too long.

@PaulRBerg
Copy link
Member Author

which word should we use as a replacement?

"Total"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants