fix: nft descriptor base64 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
You missed this:
v2-core/src/SablierV2NFTDescriptor.sol
Line 95 in 055159f
It should be changed to:
assetAddress: vars.asset.toHexString()The contracts formatting fails, I think we should set it of in the test file.
|
Good catch! Fixing now |
test: update hard-coded values test: use LibString to remove data URI prefix Closes #616
PaulRBerg
force-pushed
the
fix/nft-descriptor-base64
branch
from
055159f
to
c0fc90f
Compare
|
Looks like it's working onw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andreivladbrg, please review urgently 🙏