Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert integration tests to unit tests #626

Merged
merged 6 commits into from
Jul 23, 2023
Merged

refactor: convert integration tests to unit tests #626

merged 6 commits into from
Jul 23, 2023

Conversation

PraneshASP
Copy link
Contributor

Resolves #620

PaulRBerg
PaulRBerg requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Left a suggestion below

test/unit/concrete/comptroller/flash-fee/flashFee.t.sol Outdated Show resolved Hide resolved
@PraneshASP PraneshASP requested a review from PaulRBerg July 20, 2023 18:31
PaulRBerg
PaulRBerg approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to move these comptroller fuzz tests over to unit, but otherwise LGTM.

Thanks @PraneshASP!

@PaulRBerg PaulRBerg merged commit b5d02b7 into sablier-labs:main Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg PaulRBerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert integration tests to unit tests
2 participants
@PraneshASP @PaulRBerg