Updating .tree file in adminable_unit_test #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Thanks for the PR, @SensationalShubham. Two change requests:
- Remove the "Scenario" line. BTT is inspired by Gherkin, but it is not striving to be Gherkin.
- Update the modifiers in
transferAdmin.t.solto match the new tree
I will also make a few wording suggestions later today.
|
Also, for future PRs: could you make your branch name more specific, please? Something like |
|
I got it, I'll name them more precisely and start making changes as you suggested. |
PaulRBerg
approved these changes
Jul 24, 2023
|
Closing in favor of #641, which implemented the same changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#621
Updating the
.treefile oftransferAdmin.t.solfrom folderAdminableunder unit tests to make it more Understandable & Readable by using Cucumber's Gherkin syntaxGave more clarity about the 2 Admins in the 8th line from the previous file.