Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change disclaimer when the nft is non-transferable #821

Merged
merged 1 commit into from
Feb 11, 2024
Merged

refactor: change disclaimer when the nft is non-transferable #821

merged 1 commit into from
Feb 11, 2024

Conversation

andreivladbrg
Copy link
Member

Closes #818

smol-ninja
smol-ninja approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PaulRBerg
PaulRBerg requested changes Feb 10, 2024
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreivladbrg, left some requests

src/SablierV2NFTDescriptor.sol Outdated Show resolved Hide resolved
src/SablierV2NFTDescriptor.sol Outdated Show resolved Hide resolved
@andreivladbrg andreivladbrg force-pushed the refactor/nft-transferability-note branch from 48a8768 to e8c6047 Compare February 10, 2024 18:54
@andreivladbrg andreivladbrg force-pushed the refactor/nft-transferability-note branch from e8c6047 to e6ee3ee Compare February 10, 2024 19:27
@andreivladbrg andreivladbrg force-pushed the refactor/nft-transferability-note branch from e6ee3ee to 56f51be Compare February 10, 2024 20:12
@andreivladbrg
Copy link
Member Author

@PaulRBerg all good now?

PaulRBerg
PaulRBerg approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@andreivladbrg andreivladbrg merged commit 7f0a642 into staging Feb 11, 2024
8 of 9 checks passed
@andreivladbrg andreivladbrg deleted the refactor/nft-transferability-note branch March 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smol-ninja smol-ninja smol-ninja approved these changes

@PaulRBerg PaulRBerg PaulRBerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreivladbrg @smol-ninja @PaulRBerg