Remove protocol fee #839
Merged
Remove protocol fee #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
refactor/remove-protocol-fee
branch
2 times, most recently
from
82c58dd
to
898a290
Compare
refactor: remove comptroller test: update tests accordingly chore: update gas snapshot test: remove outdated comments
smol-ninja
force-pushed
the
refactor/remove-protocol-fee
branch
from
2eff927
to
0e218d7
Compare
smol-ninja
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Looks good. I have rebased from staging and added a commit: https://github.com/sablier-labs/v2-core/compare/2eff9279ab7429267448bbf8d4807b32b3addb16..0e218d7cf44e4f0f7daedd8c3cb4fe95b9395757 that removes unused imports and fixes some NatSpec. Kindly review before merging.
PaulRBerg
requested changes
Mar 11, 2024
thanks, the commit looks good |
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* refactor: remove protocol fee refactor: remove comptroller test: update tests accordingly chore: update gas snapshot test: remove outdated comments * chore: update some inherited components comments * refactor: remove unused imports and improve natspec * docs: improve natspec --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* refactor: remove protocol fee refactor: remove comptroller test: update tests accordingly chore: update gas snapshot test: remove outdated comments * chore: update some inherited components comments * refactor: remove unused imports and improve natspec * docs: improve natspec --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://github.com/sablier-labs/company-discussions/discussions/2, this PR removes the protocol fees.
With this change, it was possible to remove:
SablierV2ComptrollercontractSablierV2Basecontract