feat: disallow zero startTime in dynamic and tranched #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
feat/disallow-zero-startTime
branch
from
29123e3 to
bb0566e
Compare
andreivladbrg
force-pushed
the
feat/disallow-zero-startTime
branch
from
bb0566e to
2309ea1
Compare
smol-ninja
requested changes
Mar 16, 2024
test: when start time is zero in create function from dynamic and tranched test: fuzz start time starting from 1 test: move common invariants in Lockup test: remove no longer needed invariants chore: update Precompiles
andreivladbrg
force-pushed
the
feat/disallow-zero-startTime
branch
from
2309ea1 to
16aea10
Compare
|
@smol-ninja I have updated the branch with your feedback, does it look good? |
Merged
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
test: when start time is zero in create function from dynamic and tranched test: fuzz start time starting from 1 test: move common invariants in Lockup test: remove no longer needed invariants chore: update Precompiles
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
test: when start time is zero in create function from dynamic and tranched test: fuzz start time starting from 1 test: move common invariants in Lockup test: remove no longer needed invariants chore: update Precompiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #851