Check start time in Linear _calculateStreamedAmount
#941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
changed the title
_calculateStreamedAmount
smol-ninja
requested changes
Jun 7, 2024
test/integration/concrete/lockup-linear/streamed-amount-of/streamedAmountOf.tree
Show resolved
Hide resolved
smol-ninja
reviewed
Jun 7, 2024
test/integration/concrete/lockup-linear/streamed-amount-of/streamedAmountOf.t.sol
Show resolved
Hide resolved
PaulRBerg
requested changes
Jun 7, 2024
can you please provide more details? (it is a tricky situation here because we have common tests in
yes, it would be helpful, tho, imo it is a low priority atm |
|
We already have an open issue to use Bulloak across the repo. Its planned for the next release: #799 |
smol-ninja
approved these changes
Jun 10, 2024
…Amount test: test streamedAmountOf when cliff time is zero and the stream is PENDING test: correct tree branches in streamedAmountOf
andreivladbrg
force-pushed
the
fix/check-start-time
branch
from
9605a84
to
1e7b6bd
Compare
test/integration/concrete/lockup-linear/streamed-amount-of/streamedAmountOf.t.sol
Show resolved
Hide resolved
Merged
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
…Amount (#941) test: test streamedAmountOf when cliff time is zero and the stream is PENDING test: correct tree branches in streamedAmountOf
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
…Amount (#941) test: test streamedAmountOf when cliff time is zero and the stream is PENDING test: correct tree branches in streamedAmountOf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #940
Closes #938