Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use latest proxy #116

Merged
merged 1 commit into from
Jul 1, 2023
Merged

refactor: use latest proxy #116

merged 1 commit into from
Jul 1, 2023

Conversation

PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg changed the title Refactor/use latest proxy refactor: use latest proxy Jun 28, 2023
@PaulRBerg
Copy link
Member Author

FYI @andreivladbrg I have merged all PRs in the prb-proxy repo. I'll cut a new release tomorrow (4.0.0-beta.6), and then I will update this PR to use the new beta version.

@PaulRBerg
Copy link
Member Author

@andreivladbrg could you review this, please?

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 component or components?

IPRBProxyPlugin // 0 inherited components

ISablierV2ProxyTarget, // 0 inherited components
OnlyDelegateCall // 0 inherited component

test/integration/plugin/get-methods/getMethods.t.sol Outdated Show resolved Hide resolved
@PaulRBerg
Copy link
Member Author

0 component or components?

components (plural) - good catch

build: bump prb-proxy
docs: improve writing in NatSpec comments
refactor: remove storage imports
test: update fork block number and addresses
test: update tests according to new contract logic
@PaulRBerg PaulRBerg merged commit 90cca6c into main Jul 1, 2023
6 checks passed
@PaulRBerg PaulRBerg deleted the refactor/use-latest-proxy branch July 1, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor proxy target to call owner method onto itself
2 participants