feat: function isPercentagesSum100

[smol-ninja]

Changelog

• Closes A view function to verify the sum of percentages in MLT prior to deployment #356
• Introduces the following view function:

/// @notice Verifies if the sum of percentages in `tranches` equals 100% , i.e. 1e18.
/// @dev Reverts if the sum of percentages overflows.
/// @param tranches The tranches with their respective unlock percentages.
/// @return result True if the sum of percentages equals 100%, otherwise false.
function isPercentagesSum100(MerkleLT.TrancheWithPercentage[] calldata tranches)
    external
    pure
    returns (bool result);

[andreivladbrg]

LGTM, except that I believe the name isn’t that accurate. What if we say areValidPercentages?

@razgraf, requesting your suggestions here

[smol-ninja]

I agree that name isn't the best. It was hard to find a name for it. Even 'areValidPercentages' isn't that intuitive. How about 'isSum100'?

[andreivladbrg]

isPercentagesSum100 works for me

[PaulRBerg]

lgtm, feedback below but already addressed by me

[razgraf]

isPercentagesSum100 works 👍 GPT suggested "isTotalPercentage100" as a possible alternative for what it's worth (to avoid the sS)

[PaulRBerg]

I prefer isPercentagesSum100 over isTotalPercentage100 because the former indicates that the input is an array. The latter may give off the indication that the input is a single item.

to avoid the sS

minor issue in the grand scheme of things