-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): add provider.auto-stop-on-startup
argument
#346
Merged
acouvreur
merged 16 commits into
beta
from
153-services-started-with-docker-compose-wont-be-stopped-by-sablier-unless-hit-with-a-request-first
Jul 4, 2024
Merged
feat(providers): add provider.auto-stop-on-startup
argument
#346
acouvreur
merged 16 commits into
beta
from
153-services-started-with-docker-compose-wont-be-stopped-by-sablier-unless-hit-with-a-request-first
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds the capability to stop unregistered running instances upon startup. Previously, you had to stop running instances manually or issue an initial request that will shut down instances afterwards. With this change, all discovered instances will be shutdown. They need to be registered using labels. E.g.: sablier.enable=true Fixes #153
acouvreur
force-pushed
the
153-services-started-with-docker-compose-wont-be-stopped-by-sablier-unless-hit-with-a-request-first
branch
from
July 4, 2024 01:00
a973b78
to
dce647f
Compare
github-actions
bot
added
the
reverse-proxy
Reverse proxy integration related issue
label
Jul 4, 2024
This was
linked to
issues
Jul 4, 2024
🎉 This issue has been resolved in version 1.8.0-beta.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
acouvreur
deleted the
153-services-started-with-docker-compose-wont-be-stopped-by-sablier-unless-hit-with-a-request-first
branch
July 8, 2024 04:26
acouvreur
added a commit
that referenced
this pull request
Oct 2, 2024
This feature adds the capability to stop unregistered running instances upon startup. Previously, you had to stop running instances manually or issue an initial request that will shut down instances afterwards. With this change, all discovered instances will be shutdown. They need to be registered using labels. E.g.: sablier.enable=true Fixes #153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
provider
Issue related to a provider
released on @beta
reverse-proxy
Reverse proxy integration related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the capability to stop unregistered running instances upon startup.
Previously, you had to stop running instances manually or issue an initial request that will shut down instances afterwards.
With this change, all discovered instances will be shutdown. They need to be registered using labels. E.g.: sablier.enable=true