Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed last ctag-fields to synctoken #449

Closed
wants to merge 1 commit into from

Conversation

pfuender
Copy link

Not all fields have been renamed from ctag to synctoken with the previous commit 50d96b4.
This caused some errors like this when creating a new calendar:

exception 'Exception' with message '\Flake\Core\Model->set(): property ctag does not exist on Baikal\Model\AddressBook' in /var/www/baikal/Core/Frameworks/Flake/Core/Model.php:63
Stack trace:

0 /var/www/baikal/Core/Frameworks/BaikalAdmin/Controller/User/AddressBooks.php(151): Flake\Core\Model->set('ctag', '1')

1 /var/www/baikal/Core/Frameworks/BaikalAdmin/Controller/User/AddressBooks.php(45): BaikalAdmin\Controller\User\AddressBooks->actionNew()

2 /var/www/baikal/Core/Frameworks/Flake/Core/Render/Container.php(62): BaikalAdmin\Controller\User\AddressBooks->execute()

3 /var/www/baikal/Core/Frameworks/Flake/Controller/Page.php(82): Flake\Core\Render\Container->execute()

4 /var/www/baikal/Core/Frameworks/BaikalAdmin/WWWRoot/index.php(81): Flake\Controller\Page->render()

5 {main}

This commit renames the last missing 'ctag' references and fixes the error above.

Thanks for merging ;-)
Pfuender

@evert evert added the bug label Feb 14, 2016
@evert
Copy link
Member

evert commented Feb 14, 2016

I'm going to take this PR one step further and completely remove the synctoken. The database has a default value, so there's no need for baikal to supply one.

@evert evert added this to the version-0.3 milestone Feb 14, 2016
@evert
Copy link
Member

evert commented Feb 15, 2016

Just did that, thanks for the report!

@evert evert closed this Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants