db bugfixes #510
Closed
db bugfixes #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes 2 bugs: - creation of empty sqlite file by system settings, if file does not exist, but dir is writable - php warnig at install, cause configured version is not defined at the very start
|
I guess this problem got introduced because warnings are now shown, whereas before they were always hidden? |
|
Yes i missed that when testing, because php warning was only written to php log. |
| @@ -129,6 +129,13 @@ function validationHook(\Formal\Form $oForm, \Formal\Form\Morphology $oMorpho) { | |||
| // We'll have to clean this up later. | |||
| $sFile = eval('return ' . $sFile . ';'); | |||
|
|
|||
| if (!file_exists($sFile)) { | |||
| $sMessage = "DB file does not exist."; | |||
| $sMessage .= "</br>You can copy a sqlite Database file from there: <strong>Core/Resources/Db/SQLite/db.sqlite</strong>"; | |||
There was a problem hiding this comment.
This is incorrect actually.. that file no longer exists, because it was actually a bad idea to ship a sqlite database, as it doesn't work for every version of sqlite. Furthermore, the sqlite database should get automatically created.
|
I think we should add the sqlite DB creation code from install then, so people can switch to sqlite in settings |
|
That's already the case. sqlite and mysql databases are now automatically generated. |
|
Ok that's nice thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes 2 bugs:
exist, but dir is writable
very start error installing baikal 0.4.1 #509