Enable invitation plugin

[benrubson]

Hi,

This PR closes #746, closes #655, enabling invitation by mail.
Admin can configure From mail address used thanks to the BAIKAL_INVITE_FROM option.

Thank you 👍

[ByteHamster]

Hi, thanks for your PR! It would be great if this could be enabled/disabled from the admin interface. Adding notifications might break something unexpectedly, so this should be disabled when upgrading existing installations and enabled when doing a fresh install.

I have not yet tried that but I think when upgrading Baikal instead of reinstalling, the definition is not added to the config file in the specific folder.

[benrubson]

Thank you for your feedback @ByteHamster :)

It would be great if this could be enabled/disabled from the admin interface.

I agree, not sure though I will have time to dig into this right now :|

I think when upgrading Baikal instead of reinstalling, the definition is not added to the config file in the specific folder.

This should be the case now as per my last commit.

This should be disabled when upgrading existing installations and enabled when doing a fresh install.

This is what should happen now :)

[ByteHamster]

I think it might be enough to add the following to Baikal/Core/Frameworks/Baikal/Model/Config/Standard.php:

    $oMorpho->add(new \Formal\Element\Text([
        "prop"  => "BAIKAL_INVITE_FROM",
        "label" => "Email invite sender address",
        "help"  => "Leave empty to disable sending invite emails"
    ]));

[benrubson]

You're right, pushed, thank you 👍

[ByteHamster]

Sounds like Travis failed due to some internal errors, not related to the code itself.

Just triggered a rebuild, it has passed now. I will try your PR in the next few days. Thanks for adding the setting!

[ByteHamster]

I tried this PR and confirmed that it works fine. Before merging, we need sabre/dav to be updated.

[benrubson]

Good news sabre-io/dav#1150 has been merged 👍

[ByteHamster]

We still need to wait for a sabre/dav release so we can include the change in the Baikal dependencies

[Tntdruid]

Any eta?

[ByteHamster]

No, I don't know anything about the sabre/dav release schedule. As soon as we have the release, we can create a Baikal release, too.

[Tntdruid]

Dav 4.0 is out now

[mc-buckets]

Excited for this!