Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing this in php 8.0 #77

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Conversation

TysonAndre
Copy link
Contributor

Note that the dev dependency php-cs-fixer doesn't have a release that
supports php 8.0 yet.
Unit tests pass locally in 8.0.0beta4

Note that the dev dependency php-cs-fixer doesn't have a release that
supports php 8.0 yet.
Unit tests pass locally in 8.0.0beta4
@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #77 into master will increase coverage by 5.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     93.76%   99.72%   +5.95%     
+ Complexity      111      110       -1     
============================================
  Files             9        9              
  Lines           385      364      -21     
============================================
+ Hits            361      363       +2     
+ Misses           24        1      -23     
Impacted Files Coverage Δ Complexity Δ
lib/EventEmitter.php
lib/Version.php
lib/Emitter.php 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
lib/WildcardEmitter.php 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775425e...ffe55f6. Read the comment docs.

@evert evert merged commit 9681386 into sabre-io:master Sep 19, 2020
@phil-davis phil-davis mentioned this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants