Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass null to $microseconds for null $seconds #88

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

TysonAndre
Copy link
Contributor

@TysonAndre TysonAndre commented Apr 25, 2021

Passing null seconds and non-null microseconds will become deprecated in php 8.1.
See https://github.com/php/php-src/pull/6879/files#r615680892 of php/php-src#6879

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thanks

@TysonAndre TysonAndre force-pushed the patch-1 branch 2 times, most recently from 3f0b46a to c1e0ed7 Compare April 25, 2021 20:29
@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #88 (563a116) into master (0c99442) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage     99.74%   99.74%           
+ Complexity      111      110    -1     
=========================================
  Files             7        7           
  Lines           397      397           
=========================================
  Hits            396      396           
  Misses            1        1           
Impacted Files Coverage Δ
lib/Loop/Loop.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c99442...563a116. Read the comment docs.

@TysonAndre
Copy link
Contributor Author

This is ready for another look - it requires two calls (or a variable length argument list) because php 7 doesn't allow passing in null to microseconds, but php 8 deprecates passing anything other than null to the optional parameter microseconds (tv_usec) when seconds (tv_sec) is null

https://php.net/stream_select

@TysonAndre
Copy link
Contributor Author

php 8.1.0alpha2 is out

@staabm this could use another look

Passing null seconds and non-null microseconds will become deprecated in php 8.1.
See https://github.com/php/php-src/pull/6879/files#r615680892
@phil-davis
Copy link
Contributor

Rebased to run the current GitHub workflows CI, which runs unit tests in all versions of PHP. Everything is passing.

@phil-davis phil-davis merged commit 6d86fd1 into sabre-io:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants