-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TZ in iTip REPLY iTip messages #465
Add TZ in iTip REPLY iTip messages #465
Conversation
3546bd6
to
e3f3c92
Compare
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
============================================
+ Coverage 98.86% 98.87% +0.01%
Complexity 1815 1815
============================================
Files 65 65
Lines 5179 5178 -1
============================================
Hits 5120 5120
+ Misses 59 58 -1
Continue to review full report at Codecov.
|
@DeepDiver1975 Can you merge this one? |
Looks good to me - I'd like to have a second pair of eyes - @staabm maybe? THX |
@evert should have a look. I am not an expert in this area |
I still haven't managed to get correct REPLY for Microsoft Outlook or Google invitations (if sent as attendee). Should this work with this fix? |
@m-a-v Can you validate your ics and tell what happened wrong by using https://icalendar.org/validator.html Not sure what you mean by getting a correct REPLY in this context. But this is a fix for several clients which fail when rendering an event with a TZID set (and the VTIMEZONE object misses ofc) |
We were working on Microsoft/Google compatibility issues when we've done this fix. I don't remember which brand was rejecting the reply messages because of invalid format. |
806a527
to
7642fd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eying this, this looks good. Awesome that compatibility is still improving
Add VTIMEZONE objects in iTip REPLY if there were present in the original message.
Allows to have well-formatted iTip REPLY messages