fix Bad file descriptor (7.4) #469

remicollet · 2019-10-09T07:16:41Z

With 7.4.0RC3

There was 1 error:

1) Sabre\VObject\Parser\MimeDirTest::testParseError
fgets(): read of 8192 bytes failed with errno=9 Bad file descriptor

This minimal fix open file in read/write mode, to avoid the new warning.

A better fix will be to detect if the stream is properly open for read in setInput

 is_resource 
 get_resource_type == "stream"
 stream_get_meta_data => "mode"

But this will be a new feature, so far away for the goal of this simple fix.

DeepDiver1975 · 2019-10-09T07:39:01Z

failing PHPStan is unrelated - 👍 from my pov

THX @remicollet

remicollet · 2019-10-09T07:59:44Z

For memory, in UPGRADINGS

. fread() and fwrite() on plain files will now throw a notice on failure,
  such as when trying to write to a read-only file resource.

staabm · 2019-10-09T09:14:36Z

thx

staabm · 2019-10-09T09:15:04Z

side-note: will allow-failures for phpstan in #470

* fix Bad file descriptor (7.4) (sabre-io#469) * travis: allow failure for phpstan for now (sabre-io#470) * travis: add php 7.4snapshot build (sabre-io#471) * Fixed typo in vobject CLI help (sabre-io#477) * Run phpstan on PHP >= 7.1 (sabre-io#483) * Add TZ in iTip REPLY messages * Added phpstan for tests folder (sabre-io#485) * Add PHONE-NUMBER value type (used for TEL in vCard 3.0) (sabre-io#486) Signed-off-by: Christian Kraus <hanzi@hanzi.cc> * use latest phpstan 0.12.5 in CI * Add PHPstorm .idea to .gitignore * Fix various typos * Prepare next iteration * Apply php-cs-fixer code style changes * Use phpunit8 where possible * Fixed phpstan level 1 errors * Make sure there is no logic change * Prevent setting foreach key beforehand * Refactored fqcn strings to ::class to allow checking with phpstan (sabre-io#495) * Added convenient development commands * Decoupled cs-fixer command from chosen tool * Use phpunit 9 where possible * Replace assertRegExp with assertMatchesRegularExpression in unit test * fix an incomplete phpdoc type annotation * php-cs-fixer fixes * Ignore phpdoc_summary check Seriously you want me to put a full stop directly after a link?? * Drop php < 7.1, pull composer / travis changes from upstream * Release 4.3.4 Co-authored-by: Remi Collet <remi@remirepo.net> Co-authored-by: Markus Staab <maggus.staab@googlemail.com> Co-authored-by: Dominik <dominik@tobschall.de> Co-authored-by: Jeroen van Oort <jvanoort@simplexis.nl> Co-authored-by: Renaud BOYER <rboyer@linagora.com> Co-authored-by: Christian Kraus <github@hanzi.cc> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Michael Stilkerich <ms@mike2k.de>

* fix Bad file descriptor (7.4) (sabre-io#469) * travis: allow failure for phpstan for now (sabre-io#470) * travis: add php 7.4snapshot build (sabre-io#471) * reduce phpstan level back to 0, as level 1 is failing right now (sabre-io#472) * reduce phpstan level back to 0, as level 1 is failing right now * travis: no longer allow failures for phpstan * Fixed typo in vobject CLI help (sabre-io#477) * Release 4.2.1 (sabre-io#479) * Release 4.2.1 * Update CHANGELOG.md * Prepare next iteration (sabre-io#480) * Run phpstan on PHP >= 7.1 (sabre-io#483) * Add TZ in iTip REPLY messages * Added phpstan for tests folder (sabre-io#485) * Add PHONE-NUMBER value type (used for TEL in vCard 3.0) (sabre-io#486) Signed-off-by: Christian Kraus <hanzi@hanzi.cc> * use latest phpstan 0.12.5 in CI * Add PHPstorm .idea to .gitignore * Fix various typos * Release 4.2.2 (sabre-io#490) * Release 4.2.2 * Update CHANGELOG.md * Prepare next iteration * Update dependencies and code style tools * Remove unneeded 'bootstrap' line from phpstan.neon * Apply php-cs-fixer code style changes * run php-cs-fixer in CI * php-cs-fixer must be at least 2.16.1 for PHP 7.4 * Use phpunit8 where possible * Fixed phpstan level 1 errors * Make sure there is no logic change * Prevent setting foreach key beforehand * Refactored fqcn strings to ::class to allow checking with phpstan (sabre-io#495) * Release 4.3.0 (sabre-io#497) * Update CHANGELOG.md * Update Version.php * Added phpstan to dev dependencies * Reset bin-dir config * Added convenient development commands * Cleaned up .gitignore These entries should be in the developer's global .gitignore * cs-fixer: don't check only the lib folder * Decoupled cs-fixer command from chosen tool * Standardize CI * Use phpunit 9 where possible * Only upload coverage when it has been collected * Replace assertRegExp with assertMatchesRegularExpression in unit test * fix an incomplete phpdoc type annotation * Release 4.3.1 * Adjust boolean vars in .travis.yml to prepare for PHP8.0 * Run unit tests on PHP8 * Fixup calendar parameter to Broker parseEvent * Release 4.3.2 * Remove Pacific-New obsolete timezone * Do composer remove --no-update in Travis * Use min php-cs-fixer 2.16.7 * Release 4.3.3 Co-authored-by: Remi Collet <remi@remirepo.net> Co-authored-by: Markus Staab <maggus.staab@googlemail.com> Co-authored-by: Dominik <dominik@tobschall.de> Co-authored-by: Jeroen van Oort <jvanoort@simplexis.nl> Co-authored-by: Renaud BOYER <rboyer@linagora.com> Co-authored-by: Christian Kraus <github@hanzi.cc> Co-authored-by: Thomas Müller <thomas.mueller@tmit.eu> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Michael Stilkerich <ms@mike2k.de>

* fix Bad file descriptor (7.4) (sabre-io#469) * travis: allow failure for phpstan for now (sabre-io#470) * travis: add php 7.4snapshot build (sabre-io#471) * reduce phpstan level back to 0, as level 1 is failing right now (sabre-io#472) * reduce phpstan level back to 0, as level 1 is failing right now * travis: no longer allow failures for phpstan * Fixed typo in vobject CLI help (sabre-io#477) * Release 4.2.1 (sabre-io#479) * Release 4.2.1 * Update CHANGELOG.md * Prepare next iteration (sabre-io#480) * Run phpstan on PHP >= 7.1 (sabre-io#483) * Add TZ in iTip REPLY messages * Added phpstan for tests folder (sabre-io#485) * Add PHONE-NUMBER value type (used for TEL in vCard 3.0) (sabre-io#486) Signed-off-by: Christian Kraus <hanzi@hanzi.cc> * use latest phpstan 0.12.5 in CI * Add PHPstorm .idea to .gitignore * Fix various typos * Release 4.2.2 (sabre-io#490) * Release 4.2.2 * Update CHANGELOG.md * Prepare next iteration * Update dependencies and code style tools * Remove unneeded 'bootstrap' line from phpstan.neon * Apply php-cs-fixer code style changes * run php-cs-fixer in CI * php-cs-fixer must be at least 2.16.1 for PHP 7.4 * Use phpunit8 where possible * Fixed phpstan level 1 errors * Make sure there is no logic change * Prevent setting foreach key beforehand * Refactored fqcn strings to ::class to allow checking with phpstan (sabre-io#495) * Release 4.3.0 (sabre-io#497) * Update CHANGELOG.md * Update Version.php * Added phpstan to dev dependencies * Reset bin-dir config * Added convenient development commands * Cleaned up .gitignore These entries should be in the developer's global .gitignore * cs-fixer: don't check only the lib folder * Decoupled cs-fixer command from chosen tool * Standardize CI * Use phpunit 9 where possible * Only upload coverage when it has been collected * Replace assertRegExp with assertMatchesRegularExpression in unit test * fix an incomplete phpdoc type annotation * Release 4.3.1 * Adjust boolean vars in .travis.yml to prepare for PHP8.0 * Run unit tests on PHP8 * Fixup calendar parameter to Broker parseEvent * Release 4.3.2 * Remove Pacific-New obsolete timezone * Do composer remove --no-update in Travis * Use min php-cs-fixer 2.16.7 * Release 4.3.3 * Add .gitattributes * Explicitly select PHP 8.0 in CI * Use latest php-cs-fixer 2.17.1 * Update windowszones timezone data to 2020-12-13 * Fix typos * Reassign modified date in yearly rrule * Add test * Code style * Add test for calendar expand * adjust unit test settings for time limits Some tests were testing a bug that caused an infinite loop. Annotate those tests with large, small annotations. Turn on enforceTimeLimit, failOnWarning and failOnRisky so that the annotations are enforced when unit tests are run. Add phpunit/php-invoker to the composer require-dev becaause this is required to make the enforceTimeLimit setting effective. * Release 4.3.4 * Make use of until parameter in nextMonthly function * CS FIX * CS FIX * Fix breaking tests * create testMonthlyByDayUntil * create testMonthlyByDayUntilWithImpossibleNextOccurrence * Fix setting properties with group assignment * Unit test for adding properties with group for a VCard * Adapt style * Release 4.3.5 * tests: migrate from Travis to gh-actions * Removed travis config * Minor edit to README * Run phpunit with coverage in CI * Fix deprecated usages and return types on PHP 8.1 * sync ci.yml to match other repos * Changes that should have happened for 4.3.6 * changelog and VERSION bump for 4.3.7 * EventIterator returns wrong endTime (sabre-io#534) * Reordering of the attendees should not be a signitifcant change (sabre-io#540) * Reordering of vevent should not be a significant change (sabre-io#542) * Prepare release 4.3.8 * Allow easier extension of the timezone guessing This will ease customization of timezone-guessing as it is now gets easier to extend that process with own implementations (as long as they implement the appropriate interface) This is espechially necessary when wanting to actually guess a timezone via the rules defined in the VTIMEZONE-entry (which is currently not done) * testEmptyTimeZone * Changelog for 4.4.0 * Fix Changelog * Merge github actions Co-authored-by: Remi Collet <remi@remirepo.net> Co-authored-by: Markus Staab <maggus.staab@googlemail.com> Co-authored-by: Dominik <dominik@tobschall.de> Co-authored-by: Jeroen van Oort <jvanoort@simplexis.nl> Co-authored-by: Renaud BOYER <rboyer@linagora.com> Co-authored-by: Christian Kraus <github@hanzi.cc> Co-authored-by: Thomas Müller <thomas.mueller@tmit.eu> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Michael Stilkerich <ms@mike2k.de> Co-authored-by: Stéphane <demonchaux.stephane@gmail.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Jair Cueva Junior <junior@dinhost.com.br> Co-authored-by: Parajuli Kiran <kiranparajuli589@gmail.com> Co-authored-by: Cédric Anne <cedric.anne@gmail.com> Co-authored-by: Holger Floerke <floerke@doctronic.de> Co-authored-by: Andreas Heigl <andreas@heigl.org>

* fix Bad file descriptor (7.4) (sabre-io#469) * travis: allow failure for phpstan for now (sabre-io#470) * travis: add php 7.4snapshot build (sabre-io#471) * reduce phpstan level back to 0, as level 1 is failing right now (sabre-io#472) * reduce phpstan level back to 0, as level 1 is failing right now * travis: no longer allow failures for phpstan * Fixed typo in vobject CLI help (sabre-io#477) * Release 4.2.1 (sabre-io#479) * Release 4.2.1 * Update CHANGELOG.md * Prepare next iteration (sabre-io#480) * Run phpstan on PHP >= 7.1 (sabre-io#483) * Add TZ in iTip REPLY messages * Added phpstan for tests folder (sabre-io#485) * Add PHONE-NUMBER value type (used for TEL in vCard 3.0) (sabre-io#486) Signed-off-by: Christian Kraus <hanzi@hanzi.cc> * use latest phpstan 0.12.5 in CI * Add PHPstorm .idea to .gitignore * Fix various typos * Release 4.2.2 (sabre-io#490) * Release 4.2.2 * Update CHANGELOG.md * Prepare next iteration * Update dependencies and code style tools * Remove unneeded 'bootstrap' line from phpstan.neon * Apply php-cs-fixer code style changes * run php-cs-fixer in CI * php-cs-fixer must be at least 2.16.1 for PHP 7.4 * Use phpunit8 where possible * Fixed phpstan level 1 errors * Make sure there is no logic change * Prevent setting foreach key beforehand * Refactored fqcn strings to ::class to allow checking with phpstan (sabre-io#495) * Release 4.3.0 (sabre-io#497) * Update CHANGELOG.md * Update Version.php * Added phpstan to dev dependencies * Reset bin-dir config * Added convenient development commands * Cleaned up .gitignore These entries should be in the developer's global .gitignore * cs-fixer: don't check only the lib folder * Decoupled cs-fixer command from chosen tool * Standardize CI * Use phpunit 9 where possible * Only upload coverage when it has been collected * Replace assertRegExp with assertMatchesRegularExpression in unit test * fix an incomplete phpdoc type annotation * Release 4.3.1 * Adjust boolean vars in .travis.yml to prepare for PHP8.0 * Run unit tests on PHP8 * Fixup calendar parameter to Broker parseEvent * Release 4.3.2 * Remove Pacific-New obsolete timezone * Do composer remove --no-update in Travis * Use min php-cs-fixer 2.16.7 * Release 4.3.3 * Add .gitattributes * Explicitly select PHP 8.0 in CI * Use latest php-cs-fixer 2.17.1 * Update windowszones timezone data to 2020-12-13 * Fix typos * Reassign modified date in yearly rrule * Add test * Code style * Add test for calendar expand * adjust unit test settings for time limits Some tests were testing a bug that caused an infinite loop. Annotate those tests with large, small annotations. Turn on enforceTimeLimit, failOnWarning and failOnRisky so that the annotations are enforced when unit tests are run. Add phpunit/php-invoker to the composer require-dev becaause this is required to make the enforceTimeLimit setting effective. * Release 4.3.4 * Make use of until parameter in nextMonthly function * CS FIX * CS FIX * Fix breaking tests * create testMonthlyByDayUntil * create testMonthlyByDayUntilWithImpossibleNextOccurrence * Fix setting properties with group assignment * Unit test for adding properties with group for a VCard * Adapt style * Release 4.3.5 * tests: migrate from Travis to gh-actions * Removed travis config * Minor edit to README * Run phpunit with coverage in CI * Fix deprecated usages and return types on PHP 8.1 * sync ci.yml to match other repos * Changes that should have happened for 4.3.6 * changelog and VERSION bump for 4.3.7 * EventIterator returns wrong endTime (sabre-io#534) * Reordering of the attendees should not be a signitifcant change (sabre-io#540) * Reordering of vevent should not be a significant change (sabre-io#542) * Prepare release 4.3.8 * Allow easier extension of the timezone guessing This will ease customization of timezone-guessing as it is now gets easier to extend that process with own implementations (as long as they implement the appropriate interface) This is espechially necessary when wanting to actually guess a timezone via the rules defined in the VTIMEZONE-entry (which is currently not done) * testEmptyTimeZone * Changelog for 4.4.0 * Fix Iterator method signatures This avoids warnings under PHP>=8.1 Real return types should be added before PHP 9 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> * Avoid passing null as separator for implode Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> * Prepare release 4.4.1 * Rebase fix * Add PHP8.1 CI * Remove PHPUnit update * Fix PHP8.1 tests Co-authored-by: Remi Collet <remi@remirepo.net> Co-authored-by: Markus Staab <maggus.staab@googlemail.com> Co-authored-by: Dominik <dominik@tobschall.de> Co-authored-by: Jeroen van Oort <jvanoort@simplexis.nl> Co-authored-by: Renaud BOYER <rboyer@linagora.com> Co-authored-by: Christian Kraus <github@hanzi.cc> Co-authored-by: Thomas Müller <thomas.mueller@tmit.eu> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Michael Stilkerich <ms@mike2k.de> Co-authored-by: Stéphane <demonchaux.stephane@gmail.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Jair Cueva Junior <junior@dinhost.com.br> Co-authored-by: Parajuli Kiran <kiranparajuli589@gmail.com> Co-authored-by: Cédric Anne <cedric.anne@gmail.com> Co-authored-by: Holger Floerke <floerke@doctronic.de> Co-authored-by: Andreas Heigl <andreas@heigl.org> Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix Bad file descriptor (7.4)

7859811

staabm merged commit dc4b8a6 into sabre-io:master Oct 9, 2019

remicollet deleted the issue-74 branch October 9, 2019 09:17

bcaller pushed a commit to ProtonMail/vobject that referenced this pull request Jul 27, 2020

fix Bad file descriptor (7.4) (sabre-io#469)

4c409dc

valentinbonneaud pushed a commit to ProtonMail/vobject that referenced this pull reque

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix Bad file descriptor (7.4) #469

fix Bad file descriptor (7.4) #469

remicollet commented Oct 9, 2019

DeepDiver1975 commented Oct 9, 2019

remicollet commented Oct 9, 2019

staabm commented Oct 9, 2019

staabm commented Oct 9, 2019 •

edited

Loading

fix Bad file descriptor (7.4) #469

fix Bad file descriptor (7.4) #469

Conversation

remicollet commented Oct 9, 2019

DeepDiver1975 commented Oct 9, 2019

remicollet commented Oct 9, 2019

staabm commented Oct 9, 2019

staabm commented Oct 9, 2019 • edited Loading

staabm commented Oct 9, 2019 •

edited

Loading