Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage in CI and minor edit to README #546

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 8, 2021

  1. minor edit to README
  2. produce coverage in CI

@phil-davis phil-davis self-assigned this Oct 8, 2021
@phil-davis
Copy link
Contributor Author

https://github.com/sabre-io/vobject/pull/546/checks?check_run_id=3835938727

[2021-10-08T07:33:11.163Z] ['error'] There was an error running the uploader: No coverage files located, please try use `-f`, or change the project root with `-R`

I will have a look...

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #546 (94e63e7) into master (d8a0a9a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #546      +/-   ##
============================================
- Coverage     98.73%   98.68%   -0.05%     
- Complexity     1759     1778      +19     
============================================
  Files            66       66              
  Lines          4279     4425     +146     
============================================
+ Hits           4225     4367     +142     
- Misses           54       58       +4     
Impacted Files Coverage Δ
lib/Cli.php 98.07% <ø> (+0.04%) ⬆️
lib/Property/Boolean.php 50.00% <0.00%> (-3.85%) ⬇️
lib/VCardConverter.php 98.40% <0.00%> (-0.53%) ⬇️
lib/Component.php 99.15% <0.00%> (-0.41%) ⬇️
lib/Parser/XML.php 97.50% <0.00%> (-0.04%) ⬇️
lib/Node.php 100.00% <0.00%> (ø)
lib/Document.php 100.00% <0.00%> (ø)
lib/StringUtil.php 100.00% <0.00%> (ø)
lib/FreeBusyData.php 98.59% <0.00%> (ø)
lib/Property/Uri.php 100.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf6d36...94e63e7. Read the comment docs.

@phil-davis phil-davis changed the title Minor edit to README Coverage in CI and minor edit to README Oct 8, 2021
@phil-davis phil-davis merged commit eb3d10e into sabre-io:master Oct 8, 2021
@phil-davis phil-davis deleted the test-ci-20211008 branch October 8, 2021 07:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant