Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations warnings on PHP 8.1 #557

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Dec 7, 2021

Related to #556

This avoids warnings under PHP>=8.1
Real return types should be added before PHP 9

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #557 (07a329e) into master (0a2e27c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #557   +/-   ##
=========================================
  Coverage     98.34%   98.34%           
- Complexity     1848     1884   +36     
=========================================
  Files            71       71           
  Lines          4521     4536   +15     
=========================================
+ Hits           4446     4461   +15     
  Misses           75       75           
Impacted Files Coverage Δ
lib/Parser/MimeDir.php 99.56% <ø> (ø)
lib/Property.php 98.99% <ø> (ø)
lib/Property/Binary.php 100.00% <ø> (ø)
lib/Property/FloatValue.php 96.42% <ø> (ø)
lib/Property/ICalendar/CalAddress.php 100.00% <ø> (ø)
lib/Property/ICalendar/Duration.php 100.00% <ø> (ø)
lib/Property/ICalendar/Period.php 100.00% <ø> (ø)
lib/Property/Time.php 97.50% <ø> (ø)
lib/Property/Uri.php 100.00% <ø> (ø)
lib/Property/UtcOffset.php 100.00% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2e27c...07a329e. Read the comment docs.

@phil-davis phil-davis self-requested a review December 7, 2021 09:30
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks.

@phil-davis phil-davis merged commit 015d5a9 into sabre-io:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants