Yearly rrule compliance by the iterator #656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
=========================================
Coverage 98.78% 98.78%
- Complexity 1868 1869 +1
=========================================
Files 71 71
Lines 5253 5254 +1
=========================================
+ Hits 5189 5190 +1
Misses 64 64 ☔ View full report in Codecov by Sentry. |
| 'FREQ=YEARLY;BYMONTH=6;BYDAY=-1FR;UNTIL=20250901T000000Z', | ||
| '2023-09-01 12:00:00', | ||
| [ | ||
| '2023-09-01 12:00:00', |
There was a problem hiding this comment.
Note: the existing behavior is that this RRULE creates this event on 2023-09-01 and a recurrence on 2023-09-29, as well as the expected recurrences in June of 2024 and 2025.
IMO it is a separate issue about whether the first occurrence on 2023-09-01 should happen - the issue and this PR are not about that.
There was a problem hiding this comment.
Yes, having the first day not following the RRule pattern is a violation of the RFC, so maybe a validation error is needed somewhere...
There was a problem hiding this comment.
Yes, having the first day not following the RRule pattern is a violation of the RFC, so maybe a validation error is needed somewhere...
We are already being flexible and allowing the first/start day to not have to be a match for the RRULE pattern. And the code schedules that start day. So I suppose we had better keep that behavior, otherwise there would be a BC break.
There was a problem hiding this comment.
I like the flexibility here, so +1
|
I added a couple more test scenarios just to cover when the specified start date is in a month before/the same as/after the month where the recurring event should happen. It passes. |
There was a problem hiding this comment.
LGTM
I tried some similar-style combinations of MONTHLY rules with various "by day" specs and starting on a day that is not one of the days selected by the rule. All things that I tried resulted in reasonable recurrences being scheduled, so there does not seem to be any problem at the MONTHLY/BYDAY level.
Make the RRuleIterator always follow the yearly RRULE even when start date does not follow the rule. Should solve #626