Backport fix for "Passing a closed resource to Service parse or expect" to 2.2 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.2 #298 +/- ##
============================================
- Coverage 97.06% 96.07% -1.00%
- Complexity 116 124 +8
============================================
Files 13 13
Lines 511 484 -27
============================================
- Hits 496 465 -31
- Misses 15 19 +4 ☔ View full report in Codecov by Sentry. |
remove undefined assertIsResource from test ignore 'Else branch is unreachable' message on old phpstan lock php-cs-fixer to 3.63.2
phil-davis
force-pushed
the
backport-296-to-2.2
branch
from
d8549d8
to
fc72abd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the code related to issue #297 from PR #296 to the 2.2 branch.
And apply code-style changes that the latest php-cs-fixer 3.64 makes.php-cs-fixer 3.64 wants to apply trailing-comma to
list(a,b,c,)as part of the latestSymfonycode style.The old php-cs-fixer v2 does not know about that.
So for this 2.2 branch we can lock the new php-cs-fixer to 3.63.2 so that it does not do any code-style changes.
That lets the CI pass.
In future we will probably drop the support for PHP 7.1 7.2 7.3 and therefore can stop using php-cs-fixer v2. I will do that for a 2.3 series "some day".