Handle filtering by name and minor exceptions #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @sabre1041, first of all thank you for your effort, with this PR I would like to address some issues I faced:
[v] Add the name as a field_selector, appending it if there are other selectors.
[v] Since the "name" parameter is handled differently, I removed it from the list when enriching the client options
Wrapped the event loop in a try/catch to handle generic connectivity exceptions (API server unavailability, etc) to avoid the rulebook to exit
Added the field_selectors documentation in the README
Now the flow is smooth, I tested it the whole morning with different combinations and kept it running, and it's still working like a charm.
Hope this is useful,
Ale
[1] kubernetes-client/python#2076