Move away from using the body var for Jinja2 templates #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from
template.render(body=foobar)
to a more dynamic approach.make_dict()
is there to simplify validation of various source data types (eg creating a dict from a list of tuples etc). This collectively should allow and encourage greater re-use of J2 templates throughout a given app.BC Break: This will mean that any templates which currently use
{{ body.foobar }}
will need to switch to{{ foobar }}
, which is a pretty noticeable BC break, however given fastapi-mail is currently v0.x I think that's likely acceptable. There are workarounds to attempt to provide both levels of functionality if a smoother transition is desired but I'm not sure they're fool proof.