Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor transaction submitted for execution #1990

Merged
merged 23 commits into from
Aug 30, 2023
Merged

Monitor transaction submitted for execution #1990

merged 23 commits into from
Aug 30, 2023

Conversation

elgatovital
Copy link
Contributor

Handles #1987

Changes proposed in this pull request:

  • Persist tx data submitted to execution locally
  • Get tx receipt and update tx status to pending if it was not yet indexed

@gnosis/mobile-devs

@elgatovital elgatovital self-assigned this Aug 28, 2023
@elgatovital elgatovital marked this pull request as ready for review August 28, 2023 14:19
rmeissner
rmeissner requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@rmeissner rmeissner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the new repository

Edit: Also a couple view models have new logic which should also be tested

@elgatovital
Copy link
Contributor Author

Please add tests for the new repository

Edit: Also a couple view models have new logic which should also be tested

yes, already have task for it #1963

@rmeissner
Copy link
Member

We should not merge new logic without tests. It makes little sense to do the tests in a separate PR 🤔

@elgatovital elgatovital requested a review from rmeissner August 29, 2023 12:41
biafra23
biafra23 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@biafra23 biafra23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@elgatovital elgatovital requested a review from rmeissner August 29, 2023 16:23
@rmeissner rmeissner dismissed their stale review August 30, 2023 07:28

While not fully fixed, this should not block this PR anymore

@biafra23 biafra23 merged commit 6f7603d into master Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@biafra23 biafra23 deleted the feature/issue_1987_tx_monitor branch August 30, 2023 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmeissner rmeissner rmeissner left review comments

@DmitryBespalov DmitryBespalov DmitryBespalov approved these changes

@biafra23 biafra23 biafra23 approved these changes

Assignees

@elgatovital elgatovital

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elgatovital @rmeissner @biafra23 @DmitryBespalov