Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-kit): add ordering props to getPendingTransactions #1011

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Oct 15, 2024

What it solves

Resolves #1010

How this PR fixes it

Adds parameters to filter pending transactions using

  • nonce
  • limit
  • offset
  • has_confirmations

@dasanra dasanra requested a review from DaniSomoza October 15, 2024 14:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11348788177

Details

  • 7 of 13 (53.85%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 76.251%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-kit/src/SafeApiKit.ts 7 13 53.85%
Totals Coverage Status
Change from base Build 11347196299: -0.5%
Covered Lines: 784
Relevant Lines: 961

💛 - Coveralls

@dasanra dasanra merged commit 4a9546f into development Oct 15, 2024
19 checks passed
@dasanra dasanra deleted the feat/add-api-kit-params branch October 15, 2024 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@dasanra dasanra linked an issue Oct 15, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[api-kit] Missing ordering parameters for getPendingTransactions
3 participants