more precise types for signature type in confirmations #1043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
packages/types-kit
includes changes to enhance type safety and consistency in the codebase. The most significant changes involve the introduction of a newSignatureTypes
constant and the correspondingSignatureType
type and modifying existing types to utilize these new definitions.Enhancements to type safety and consistency:
packages/types-kit/src/types.ts
: AddedSignatureTypes
constant andSignatureType
type for improved type safety.packages/types-kit/src/types.ts
: UpdatedSafeMultisigConfirmationResponse
to use the newSignatureType
type instead of a string.Reference to the
SafeSignatureType
enum insafe-eth-py
andsafe-transaction-service
: