Set safeTxGas=0 when safeVersion>=1.3.0 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
katspaugh
reviewed
Dec 7, 2021
| )) | ||
| let safeTxGas: number | ||
| const safeVersion = await safeContract.getVersion() | ||
| if (semverSatisfies(safeVersion, '>=1.3.0')) { |
There was a problem hiding this comment.
Maybe put '>=1.3.0' in some sort of config, similar to safe-react?
Or at least a constant.
iamacook
approved these changes
Dec 7, 2021
| )) | ||
| let safeTxGas: number | ||
| const safeVersion = await safeContract.getVersion() | ||
| if (semverSatisfies(safeVersion, '>=1.3.0')) { |
There was a problem hiding this comment.
Maybe it makes sense to create a lookup for the versions?
|
|
||
| it('proposeTransaction', async () => { | ||
| const safeTxData: SafeTransactionDataPartial = { | ||
| to: '0xa33d2495760462018275994d85117600bd58221e', | ||
| data: '0x', | ||
| value: '123456789', | ||
| operation: 1, | ||
| safeTxGas: 123, | ||
| safeTxGas: 0, | ||
| baseGas: 0, | ||
| gasPrice: 0, | ||
| gasToken: '0x0000000000000000000000000000000000000000', |
There was a problem hiding this comment.
Do you use the a ZERO_ADDRESS often? Might be worthwhile creating a constant for it.
There was a problem hiding this comment.
It is only used twice in this test file
DiogoSoaress
reviewed
Dec 7, 2021
germartinez
force-pushed
the
safeTxGas-0
branch
from
6f8ae7b to
bedee8d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #100