Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Web3 tests #148

Merged
merged 8 commits into from
Jan 19, 2022
Merged

Fix Web3 tests #148

merged 8 commits into from
Jan 19, 2022

Conversation

germartinez
Copy link
Member

What it solves

Resolves #147

@germartinez germartinez linked an issue Jan 19, 2022 that may be closed by this pull request
Fix Web3 tests #147
Closed
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

iamacook
iamacook approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good dude! I just have one question about the casting to AbiItem[]. I think it's related to this though?

packages/safe-core-sdk/src/ethereumLibs/Web3Adapter.ts Show resolved Hide resolved
@germartinez germartinez merged commit c7e6490 into development Jan 19, 2022
@germartinez germartinez deleted the fix-web3-tests branch January 19, 2022 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamacook iamacook iamacook approved these changes

@DiogoSoaress DiogoSoaress Awaiting requested review from DiogoSoaress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Web3 tests
2 participants
@germartinez @iamacook