Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-3770 #178

Merged
merged 6 commits into from
Feb 22, 2022
Merged

EIP-3770 #178

merged 6 commits into from
Feb 22, 2022

Conversation

germartinez
Copy link
Member

What it solves

Resolves #74

  • Implements EIP-3770 in safe-core-sdk-utils

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@germartinez germartinez requested a review from iamacook February 22, 2022 11:04
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Very thorough testing

chainId: number
}

export const networks: NetworkShortName[] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these related to contracts we currently have deployed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I took them from safe-deployments

@germartinez germartinez merged commit 5486a10 into development Feb 22, 2022
@germartinez germartinez deleted the eip-3770 branch February 22, 2022 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants