Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development #210

Merged
merged 30 commits into from
Jul 12, 2022
Merged

Development #210

merged 30 commits into from
Jul 12, 2022

Conversation

germartinez
Copy link
Member

What it solves

Resolves #

How this PR fixes it

mmv08 and others added 28 commits April 12, 2022 17:20
@mmv08
Fix broken transaction docs link
b07ad60
@germartinez
Merge pull request #193 from gnosis/mikheevm-patch-1
ee078c2 
Fix broken transaction docs link
@germartinez
Merge branch 'main' into development
2a2b809
@germartinez
Update Github links
8ad5fb7
@germartinez
Merge pull request #198 from safe-global/safe-global-links
0027f8c 
Update Github links
@germartinez
Use fixed safe-deployments version
1538a0c
@germartinez
Add signTypedData types
a3f4dbb
@germartinez
Generate EIP-712 signature from utils package
f04ffb1
@germartinez
Add signTypedData method in ethers-lib
89554bb
@germartinez
Add signTypedData in web3-lib
fbd3663
@germartinez
Make signTypedData method available
79ec64a
@germartinez
Add comments
6c2a031
@germartinez
Fix signature tests
2c49b06
@germartinez
Remove owner condition when calling signTransactionHash
9d2ed14
@germartinez
Add senderSignature prop to proposeTransaction
956e0f4
@germartinez
Update proposeTransaction docs
e0cc8f2
@germartinez
Update proposeTransaction tests
8dbefd7
@germartinez
Fix SafeTransactionService interface
0f71713
@germartinez
Remove outdated test
5c3434f
@germartinez
Extract semver condition to constant
0e8865f
@germartinez
Add isSignerTypedData typecheck
2c0a0dc
@germartinez
Refactor web3 signTypedData with send instead of sendAsync
403463e
@germartinez
Fix web3 signTypedData
2fb8b9e
@germartinez
Merge pull request #209 from safe-global/propose-tx-delegates
d34b3a5 
Allow Safe delegates to propose transactions
@germartinez
Code formatting
a5d8044
@germartinez
Merge branch 'development' into signtypeddata
8a7e22b
@germartinez
Update docs
8d2f4a9
@germartinez
Merge pull request #208 from safe-global/signtypeddata
cfa4a0b 
Support Sign Typed Data
@github-actions
Copy link

CLA Assistant Lite:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger the CLA Action by commenting recheckcla in this Pull Request

@germartinez germartinez marked this pull request as ready for review June 20, 2022 22:46
@germartinez
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@0x7An
Copy link

0x7An commented Jul 6, 2022 •
edited
Loading

@germartinez thanks! can we merge this? 🙇‍♂️

@germartinez germartinez merged commit 06d9505 into main Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@germartinez @0x7An @mmv08