MultiSend #23
MultiSend #23
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
src/utils/transactions/utils.ts
Outdated
| return encoded.slice(2) | ||
| } | ||
|
|
||
| export const encodeMultiSendData = (txs: SafeBasicTransactionData[]): string => { |
There was a problem hiding this comment.
Do we have tests for this method`?
There was a problem hiding this comment.
There is this one (not a unit test of the method), but I will add a contract call too: https://github.com/gnosis/safe-core-sdk/pull/23/files#diff-c2f7973a9f5098cdc60417d715910ce586a7eae4a43b63cd65935b545ca99791R214
There was a problem hiding this comment.
Added the multisend with contract calls here: https://github.com/gnosis/safe-core-sdk/pull/23/files#diff-5535ed79ff3f49019cd635181eeed03ad747f8fb0d63b014008287dba9e8fe77R249
|
Thanks @rmeissner! |
| ) | ||
| } | ||
|
|
||
| get safeContract() { |
There was a problem hiding this comment.
i'm not an oop expert but this getter is the same as just accessing the property, why make it private?
There was a problem hiding this comment.
to prevent it from being modified
There was a problem hiding this comment.
TIL you also can't access them otherwise. Btw, in safe-apps-sdk we don't use it anymore because of safe-global/safe-apps-sdk#141
No description provided.