Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Safe Ethers Adapter #28

Merged
merged 21 commits into from
Jun 3, 2021
Merged

Add Safe Ethers Adapter #28

merged 21 commits into from
Jun 3, 2021

Conversation

rmeissner
Copy link
Member

@rmeissner rmeissner commented May 27, 2021 •
edited
Loading

Adds a Ethers signer that proposes a Safe transaction to the interface when used

  • Add Ethers signer that pushes transactions to Safe service
  • Add example how to use signer
  • Clean up hardcoded constants
  • Add tests
  • Update readme
  • Add method documentation

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@rmeissner rmeissner requested a review from germartinez June 2, 2021 09:31
@rmeissner rmeissner marked this pull request as ready for review June 2, 2021 09:32
germartinez
germartinez approved these changes Jun 2, 2021
View reviewed changes
packages/safe-ethers-adapters/src/service.ts Outdated Show resolved Hide resolved
packages/safe-ethers-adapters/src/signer.ts Outdated Show resolved Hide resolved
packages/safe-ethers-adapters/src/utils.ts Show resolved Hide resolved
packages/safe-ethers-adapters/src/utils.ts Show resolved Hide resolved
packages/safe-ethers-adapters/tests/signer.test.ts Show resolved Hide resolved
@rmeissner rmeissner merged commit 33ded36 into main Jun 3, 2021
@rmeissner rmeissner deleted the feature/safe_ethers_adapter branch June 3, 2021 11:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germartinez germartinez germartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmeissner @germartinez