Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(safe-core-sdk) Add nonce to Safe config methods #61

Merged
merged 4 commits into from
Sep 16, 2021
Merged

(safe-core-sdk) Add nonce to Safe config methods #61

merged 4 commits into from
Sep 16, 2021

Conversation

germartinez
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@germartinez germartinez requested a review from mmv08 September 6, 2021 11:44
@mmv08
Copy link
Member

mmv08 commented Sep 6, 2021

Do you think it makes sense to take opts: TransactionDataPartial instead of a single nonce like createTransaction? I can imagine rare use cases where this is needed: for example, using meta transactions.

https://github.com/gnosis/safe-core-sdk/blob/39982001593097892fc614252564293c01988e34/packages/safe-core-sdk-types/src/types.ts#L23

@germartinez germartinez changed the title Add nonce to Safe config methods (safe-core-sdk) Add nonce to Safe config methods Sep 14, 2021
@germartinez germartinez linked an issue Sep 15, 2021 that may be closed by this pull request
Allow passing nonce to methods building the transactions #57
Closed
@germartinez germartinez requested a review from mmv08 September 15, 2021 15:49
mmv08
mmv08 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@germartinez germartinez merged commit d1170c4 into development Sep 16, 2021
@germartinez germartinez deleted the custom-nonce-methods branch September 16, 2021 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing nonce to methods building the transactions
2 participants
@germartinez @mmv08