Get right nonce when there are pending transactions #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
germartinez
force-pushed
the
get-last-nonce
branch
from
ba4ccfc to
46f3dcb
Compare
iamacook
reviewed
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #75
How this PR fixes it
The new method
getNextNonce(safeAddress)was added to thesafe-service-clientpackage.If the given Safe has pending transactions it will return the nonce of the last pending transaction + 1.
If the given Safe has no pending transactions it will return the Safe nonce.
The returned nonce can be used to create a new
SafeTransactionbefore proposing it.