Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Oracle for cream.finance tokens #100

Merged
merged 6 commits into from
Oct 11, 2021
Merged

Feature: Oracle for cream.finance tokens #100

merged 6 commits into from
Oct 11, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Oct 8, 2021 •
edited
Loading

This PR adds an oracle that enables prices for tokens such as https://etherscan.io/token/0x76Eb2FE28b36B3ee97F3Adae0C69606eeDB2A37c

And also vaults building on top of it (like curve ib3CRV vault)

@mmv08 mmv08 requested a review from Uxio0 October 8, 2021 14:50
@mmv08 mmv08 requested a review from fmrsabino as a code owner October 8, 2021 14:50
@mmv08
remove npx
cfd047f 
Sent from my iPhone
@coveralls
Copy link

coveralls commented Oct 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1329635735

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.405%
Totals Coverage Status
Change from base Build 1320717184: 0.3%
Covered Lines: 2680
Relevant Lines: 2932
💛 - Coveralls

fmrsabino
fmrsabino approved these changes Oct 11, 2021
View reviewed changes
gnosis/eth/oracles/oracles.py Outdated Show resolved Hide resolved
@Uxio0 Uxio0 merged commit 21deda7 into master Oct 11, 2021
@Uxio0 Uxio0 deleted the feat/cream-oracle branch October 11, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@Uxio0 Uxio0 Awaiting requested review from Uxio0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmv08 @coveralls @fmrsabino @Uxio0