Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update safe-deployments to last version #1015

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Update safe-deployments to last version #1015

merged 1 commit into from
Jun 3, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented May 31, 2024

  • Update script to make directories relative, so script can be called from any folder
  • Rename constant names

@Uxio0
Update safe-deployments to last version
4ad16dd 
- Update script to make directories relative, so script can be called from any folder
- Rename constant names
@Uxio0 Uxio0 requested a review from a team as a code owner May 31, 2024 15:13
@coveralls
Copy link

coveralls commented May 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9320366520

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 93.532%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 86.16%
Totals Coverage Status
Change from base Build 9317946988: 0.01%
Covered Lines: 8055
Relevant Lines: 8612
💛 - Coveralls

falvaradorodriguez
falvaradorodriguez reviewed Jun 3, 2024
View reviewed changes
scripts/generators/generate_safe_deployments.py
DEPLOYMENTS_FOLDER = REPO_DIR + "/src/assets" # folder where the deployments are
SAFE_ETH_PY_DEPLOYMENTS_PATH = "../../gnosis/safe/safe_deployments.py" # Full path where the deployment dictionary will be stored
SAFE_DEPLOYMENTS_URL = "https://github.com/safe-global/safe-deployments.git"
SAFE_DEPLOYMENTS_VERSION = "main" # safe-deployments tag/branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: No need to release the changes, is it enough if they are in main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be alright

@Uxio0 Uxio0 merged commit c27191b into main Jun 3, 2024
7 checks passed
@Uxio0 Uxio0 deleted the update-safe-deployments branch June 3, 2024 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @falvaradorodriguez