Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EthereumNetwork using chainlist #1266

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Update EthereumNetwork using chainlist #1266

merged 2 commits into from
Aug 6, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Aug 6, 2024

No description provided.

@Uxio0 Uxio0 requested a review from a team as a code owner August 6, 2024 10:25
@Uxio0 Uxio0 force-pushed the update-chainlist branch 5 times, most recently from 11e0a22 to b930dd5 Compare August 6, 2024 12:42
@coveralls
Copy link

coveralls commented Aug 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10266882836

Details

  • 547 of 547 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.4%) to 93.891%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 86.16%
gnosis/safe/tests/utils.py 1 60.0%
gnosis/eth/clients/ens_client.py 1 59.38%
gnosis/safe/safe_tx.py 1 90.97%
Totals Coverage Status
Change from base Build 10263323736: 0.4%
Covered Lines: 8669
Relevant Lines: 9233
💛 - Coveralls

@Uxio0 Uxio0 merged commit 0393679 into main Aug 6, 2024
7 checks passed
@Uxio0 Uxio0 deleted the update-chainlist branch August 6, 2024 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @falvaradorodriguez