Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical addresses for CELO, MANTLE and X_LAYER #1359

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

dasanra
Copy link
Contributor

@dasanra dasanra commented Oct 2, 2024

Adds missing canonical addresses for

  • CELO
  • MANTLE
  • X_LAYER

Copy link
Contributor

github-actions bot commented Oct 2, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coveralls
Copy link

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11145776371

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 618 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-6.5%) to 87.008%

Files with Coverage Reduction New Missed Lines %
safe_eth/eth/utils.py 3 86.46%
safe_eth/eth/account_abstraction/bundler_client.py 3 92.5%
safe_eth/eth/tests/utils.py 6 59.52%
safe_eth/safe/tests/test_proxy_factory/test_proxy_factory.py 7 88.61%
safe_eth/eth/oracles/superfluid.py 10 54.55%
safe_eth/eth/multicall.py 10 84.96%
safe_eth/eth/oracles/kyber.py 11 59.18%
safe_eth/eth/tests/clients/test_etherscan_client.py 11 63.64%
safe_eth/eth/tests/oracles/test_kyber.py 11 57.69%
safe_eth/eth/tests/oracles/test_superfluid.py 13 43.48%
Totals Coverage Status
Change from base Build 10990349394: -6.5%
Covered Lines: 8177
Relevant Lines: 9398

💛 - Coveralls

@dasanra
Copy link
Contributor Author

dasanra commented Oct 2, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 2, 2024
@dasanra
Copy link
Contributor Author

dasanra commented Oct 2, 2024

recheck

@dasanra dasanra marked this pull request as ready for review October 2, 2024 11:14
@dasanra dasanra requested a review from a team as a code owner October 2, 2024 11:14
@moisses89
Copy link
Member

@dasanra LGTM, thanks!

@moisses89 moisses89 merged commit 4cdd289 into safe-global:main Oct 4, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@dasanra dasanra deleted the add-missing-addresses branch October 4, 2024 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants