Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typying proposer can be None #1385

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix typying proposer can be None #1385

merged 1 commit into from
Oct 15, 2024

Conversation

moisses89
Copy link
Member

Description

Safe transaction service lets create transactions without any signature, which means the proposer can be null.

@moisses89 moisses89 requested a review from a team as a code owner October 15, 2024 13:16
@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11346895789

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.592%
Totals Coverage Status
Change from base Build 11341690435: 0.001%
Covered Lines: 8924
Relevant Lines: 9535
💛 - Coveralls

@moisses89 moisses89 merged commit 6ad7539 into main Oct 15, 2024
7 checks passed
@moisses89 moisses89 deleted the fix_build_transaction_service_tx branch October 15, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moisses89 @coveralls @falvaradorodriguez @Uxio0