Update pre-commit #222
Update pre-commit #222
Conversation
| - repo: https://github.com/psf/black | ||
| rev: 22.1.0 | ||
| rev: 22.3.0 | ||
| hooks: | ||
| - id: black |
There was a problem hiding this comment.
We have this pre-commit hook but it seems that we don't declare black as a dependency.
Should we provide this in requirements-dev.txt?
There was a problem hiding this comment.
Pre-commit installs its packages independently
There was a problem hiding this comment.
Yes under a pre-commit environment. It's still not available for in the normal venv right?
There was a problem hiding this comment.
No
Ok so we don't add black to the dependencies because it's under the pre-commit.
I would say that we can remove flake8 and isort from requirements-dev.txt so that we don't have any conflict with the versions.
There was a problem hiding this comment.
I think we can remove isort, but flake8 is used by the editor (like vim or vscode). Thinking about it, I think we can add black to get auto formatting in the IDE and not remove anything, what do you think?
There was a problem hiding this comment.
I think we can remove
isort, butflake8is used by the editor (like vim or vscode). Thinking about it, I think we can add black to get auto formatting in the IDE and not remove anything, what do you think?
I think that's fine 👍
Was just wondering about the value of having those in requirements-dev.txt and also in the pre-commit. In the safe-config-service we have on both (the disadvantage is that the versions need to be kept in sync) 🤔
There was a problem hiding this comment.
I understand. IMHO is just convenience
No description provided.